New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PE-12001) Add solaris 10 #65
(PE-12001) Add solaris 10 #65
Conversation
exec { "unzip ${package_file_name}": | ||
path => '/bin:/usr/bin:/sbin:/usr/sbin', | ||
command => "gzip -d /opt/puppetlabs/packages/${package_file_name}", | ||
creates => "/opt/puppetlabs/ppackages/${_unzipped_package_name}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ppuppet
a typo? I assume this is fixed in your local changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a typo; I'll fix that, and rebase for a change to sles10 pr
cff957c
to
3d90e78
Compare
Ah, right, I just figured out why the version constraints are on the osfamily classes; because the osfamily tests will see empty catalogs if the Puppet version is not 3.8. I'll fix this up after arch. |
4641790
to
5c2d39d
Compare
Had to add two resources to stop the pe-puppet and pe-mcollective. It's also necessary that they (or at least the pe-puppet service stop) happen at the very end or the run is interrupted. There may be better ways to do this then what I currently have arranged. |
Manually tested an upgrade of Solaris10 3.8.2 -> 2015.2.x with this patch. |
6952a9f
to
64901e6
Compare
Based on the work done for PE-10915, add an osfamily class for Solaris 10 and update the install and install/remove_packages classes. * as with SLES10, we're relying on a pe_packages file mount to have been set up on the master in order to be able to download the puppet-agent package we are upgrading too. * the downloaded package is unzipped * previous pe-* packages are manually uninstalled prior to installing pe-puppet
And a fix to the solaris/nexenta spec in puppet_agent_spec.rb to add architecture. This began failing the validate_re check in init.pp once manifest/params.pp had 'Solaris' added to the osfamily case for supported platforms, and so was no longer failing immediately.
Removing the PUPpuppet and PUPmcollective packages does not stop the running services. I've added service resources for both of the old PE services to ensure they are stopped. However, it is also critical that they are stopped as the very last act of the catalog, because stopping the pe-puppet service, at least on Solaris, terminates the run in mid progress. Originally I had the services stopped in the prepare stage, but had to reposition them.
64901e6
to
477c1ab
Compare
Verified upgrade from 3.8.2->2015.2.1, Sol10 agent from vmpool upgraded sucessfully, |
Based on #63. This should not be merged until that PR is.