(maint) PDK Update 2.7.5 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
pdk-update
branch
2 times, most recently
from
85d02b8
to
2f172df
Compare
AriaXLi
force-pushed
the
pdk-update
branch
3 times, most recently
from
2c43ec7
to
9e65ac8
Compare
mhashizume
reviewed
Aug 25, 2023
mhashizume
reviewed
Aug 25, 2023
AriaXLi
force-pushed
the
pdk-update
branch
2 times, most recently
from
7fbe819
to
c58c704
Compare
This commit updates and applies the 2.7.5 PDK template to prepare for the v1.15.0 release and make using the GitHub Changelog Generator easier.
AriaXLi
force-pushed
the
pdk-update
branch
5 times, most recently
from
0ea51fe
to
cac524c
Compare
mhashizume
reviewed
Sep 14, 2023
joshcooper
reviewed
Sep 14, 2023
joshcooper
reviewed
Sep 14, 2023
|
I'm a little concerned about the amount of changes. Would it be possible to split this up and just bump stdlib dependency in metadata.json and release the module using the old release automation? |
donoghuc
reviewed
Sep 15, 2023
When updating the module to PDK 2.7.5, the Vox Beaker gem was removed. puppetlabs_spec_helper updated and the updated version removed the Beaker rake task which is used for acceptance testing. This commit adds the voxpupuli-acceptance gem which re-adds the Beaker rake task.
This commit includes all the changes needed to pass the validate rake/check which checks if the module adheres to the Puppet Strings style.
This commit blocks the top_scope_facts, only_variable_string, and
strinct_indent lint check for portions of manifests/install/windows.pp,
manifests/osfamily/redhat.pp, and manifests/osfamily/suse.pp respectively.
For the top_scope_facts, the check keeps on thinking
`puppet_agent::_expected_package_version` in windows.pp is a fact. For the
only_variable_string, when I try to remove the double quotes from
`"${facts['os']['release']['major']}"`, the conditional no longer works as
expected in redhat.pp. Lastly, for the strict_indent check, it thinks the
indentation for $script in redhat.pp and suse.pp is wrong but it is not.
Currentlty, the puppet_url_without_modules assumes all puppet:/// URLs are using the modules mount. pe_packages is a custom mount and does not use the modules mount.
joshcooper
approved these changes
Sep 20, 2023
seanmil
added a commit
to seanmil/puppetlabs-puppet_agent
that referenced
this pull request
Sep 27, 2023
In PR puppetlabs#663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.
seanmil
added a commit
to seanmil/puppetlabs-puppet_agent
that referenced
this pull request
Sep 27, 2023
In PR puppetlabs#663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.
seanmil
added a commit
to seanmil/puppetlabs-puppet_agent
that referenced
this pull request
Sep 28, 2023
In PR puppetlabs#663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.
seanmil
added a commit
to seanmil/puppetlabs-puppet_agent
that referenced
this pull request
Sep 28, 2023
In PR puppetlabs#663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates and applies the 2.7.5 PDK template to prepare for the v1.15.0 release