(maint) Unnest module and class names in Ruby tasks #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
approved these changes
Dec 7, 2023
|
I'm confused about this, how are task acceptance tests passing? Also this only un-nests the module definitions in the task helper. |
|
Ah, it appears acceptance tests cover the shell/powershell tasks not the ruby ones. |
|
Ok, i see what is going on better now. This is a very annoying cop, thanks for disabling it. Seems like we could use some acceptance level testing for the ruby tasks here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit a bug that had previously been resolved in :
2911a0a
Had been reintroduced by application of rubocop recommendations.
This commit reverts this change, and also adds in the correct PDK compatible block for the cop in question so this wont happen automatically again