(PE-11531) Fix Debian ensure => version #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit I assumed that I could ensure the package version on Debian based platforms using the regular X.Y.Z version. This commit fixes what is ensured on Debian platforms to `X.Y.Z-1codename`, which is what apt expects.
|
Tested out on debian 6/ubuntu 1004 agent upgrades: |
|
👍 |
| @@ -80,6 +80,12 @@ | |||
| ensure => "${package_version}-1.el${::operatingsystemmajrelease}", | |||
| * => $_package_options, | |||
| } | |||
| } elsif ($::osfamily == 'Debian') and ($package_version != 'present') { | |||
| # Workaround PUP-5802/PUP-5025 | |||
There was a problem hiding this comment.
Oh actually, is there a ticket for debian platforms that is similar to this ticket?
There was a problem hiding this comment.
Probably not. I'll clean that up in a maint commit.
There was a problem hiding this comment.
Actually, can you look for or file a ticket and update the comment?
There was a problem hiding this comment.
@MikaelSmith Created https://tickets.puppetlabs.com/browse/PUP-6097 as a clearer ticket for the general {{ensure => version}} woes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit I assumed that I could ensure the package
version on Debian based platforms using the regular X.Y.Z version.
This commit fixes what is ensured on Debian platforms to
X.Y.Z-1codename, which is what apt expects.