(maint) Fix a dependency cycle introduced on Windows by Sol11 work #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a dependency cycle introduced by Solaris 11 work. Solaris 11 requires managing config files before preparing packages, because part of preparing the package is saving /etc/puppetlabs where the configs are stored. On Windows, a dependency was introduced because the package is stored to `C:/ProgramData/Puppet Labs/...`, and config files are also stored there. So creating an order of configs before package prepare caused a requirement that C:/ProgramData/Puppet Labs exists both before and after managing config files. Fix that dependency cycle by mananging `C:/ProgramData/Puppet Labs` earlier.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a dependency cycle introduced by Solaris 11 work. Solaris 11
requires managing config files before preparing packages, because part
of preparing the package is saving /etc/puppetlabs where the configs are
stored.
On Windows, a dependency was introduced because the package is stored to
C:/ProgramData/Puppet Labs/..., and config files are also storedthere. So creating an order of configs before package prepare caused a
requirement that C:/ProgramData/Puppet Labs exists both before and after
managing config files. Fix that dependency cycle by mananging
C:/ProgramData/Puppet Labsearlier.