(MODULES-7844) Update stdlib and concat dependencies #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the upper bound for both the stdlib and concat dependencies from "< 5.0.0" to "< 6.0.0".
Sharpie
force-pushed
the
MODULES-7844-update-dependencies
branch
from
af99885
to
a471443
Compare
|
The update to using version 1.x of the hocon gem seems to have hit a fragile spot in the tests for @@ -1,13 +1,13 @@
-authorization : {
- rules : [
+authorization: {
+ rules: [
{
- "allow" : "bar",
- "match-request" : {
- "path" : "/bar",
- "type" : "path"
+ "allow": "bar",
+ "match-request": {
+ "path": "/bar",
+ "type": "path"
},
- "name" : "bar-rule",
- "sort-order" : 777
+ "name": "bar-rule",
+ "sort-order": 777
}
]My guess is something changed around whitespace since the content is correct. |
|
Yup, the problem is the removal of spaces before the Will update the relevant test fixtures. |
Sharpie
force-pushed
the
MODULES-7844-update-dependencies
branch
from
a471443
to
2e9908c
Compare
|
One testcase is still failing on Puppet 6 due to a |
This commit updates metadata.json to add Puppet 6, and Ubuntu 16.04 and 18.04
to the list of configurations supported by the puppetlabs-puppet_authorization
module.
The Travis CI matrix and Gemfile are also updated to address several issues:
- Test cells for Puppet 5.x and Puppet 6.x are added.
- The correct PUPPET_VERSION environment variable is now set by Travis
instead of PUPPET_GEM_VERSION.
- The test for Puppet 4.x is updated to use Ruby 2.1.9.
- The Gemfile is updated to allow the latest 1.x version of the hocon gem
which is the version bundled with puppet-agent 4.10 -- 6.0.
Sharpie
force-pushed
the
MODULES-7844-update-dependencies
branch
from
2e9908c
to
9edfe38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset updates the stdlib and concat dependencies so that
puppet_authorizationcan be installed into an environment using the recently released 5.0 versions of both modules. The test suite is also extended to cover Puppet 5.x and Puppet 6.x.