Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-4126) Fix file sync additional metrics #192

Merged

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Mar 22, 2023

Prior to this commit, the mbeans for the additional file sync storage metrics started with 'puppetserver:name=puppetlabs.puppet'; however, the object name of the mbeans include the hostname of the compiling server. This resulted in the api returning 404s and not collecting the metrics.

This commit replaces the 'puppet' part of the name with a glob, which should match correctly.

Prior to this commit, the mbeans for the additional file sync storage
metrics started with 'puppetserver:name=puppetlabs.puppet'; however, the
object name of the mbeans include the hostname of the compiling server.
This resulted in the api returning 404s and not collecting the metrics.

This commit replaces the 'puppet' part of the name with a glob, which
should match correctly.
@m0dular m0dular requested a review from a team as a code owner March 22, 2023 19:46
@puppet-community-rangefinder
Copy link

puppet_metrics_collector::service::puppetserver is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular
Copy link
Contributor Author

m0dular commented Mar 22, 2023

Tested this manually in a lab with CM enabled and the output shows up:

"file-sync-storage-commit-add-rm-timer": {
          "puppetserver:name=puppetlabs.pe-server-e5a7ce-0.file-sync-storage.commit-add-rm-timer": {
            "Mean": 14.20149868934494,

@elainemccloskey elainemccloskey merged commit 39dd7b2 into puppetlabs:main Apr 5, 2023
25 checks passed
@MartyEwings MartyEwings added the enhancement New feature or request label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants