Remove 127.0.0.1 special case naming #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandellP
previously approved these changes
Oct 16, 2019
|
@reidmv doesn't look like the linter likes your change to the else syntax... |
The 127.0.0.1 thing is a hold-over from before we defaulted to smart configuration of metrics collection. It isn't good UX to use that name though. We should remove it from the defaults so that users don't need to know about or be confused by this legacy 127.0.0.1 thing.
|
@RandellP heh; that would be because it's a syntax error. Mismatched braces. Force-pushing an amended commit with a fix. Oops. diff --git a/functions/hosts_with_pe_profile.pp b/functions/hosts_with_pe_profile.pp
index 23e0130..5c44afe 100644
--- a/functions/hosts_with_pe_profile.pp
+++ b/functions/hosts_with_pe_profile.pp
@@ -21,7 +21,6 @@ function puppet_metrics_collector::hosts_with_pe_profile($profile) {
title = 'Puppet_enterprise::Profile::${_profile}' and
nodes { deactivated is null and expired is null }
}").map |$nodes| { $nodes['certname'] }
- }
}
else {
$hosts = [] |
johnduarte
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 127.0.0.1 thing is a holdover from before we defaulted to smart configuration of metrics collection. It isn't good UX to use that name though. We should remove it from the defaults so that users don't need to know about or be confused by this legacy 127.0.0.1 thing.