{WIP} remove exporter class state from infra nodes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyEwings
requested review from
dylanratcliffe and
jarretlavallee
as code owners
dylanratcliffe
suggested changes
Jan 12, 2021
There was a problem hiding this comment.
Content looks good, just needs to be prettier i.e.
- If you want a blank line, just use one. Currently there is sometimes one sometimes two
- Indentation should be correct i.e.
- +2 spaces of indent on following line for every opening brace (, { or [
- -2 spaces of indent for every closing brace
- Comments should also follow indentation rules
|
@dylanratcliffe like this? |
|
@MartyEwings Almost, lines 26 though 35 inclusive should be indented 2 more spaces |
|
Thanks @dylanratcliffe fixed it... why is the styling the most difficult part for me± |
|
Much more better. Do you have puppet-lint working in vscode? That helps a lot |
dylanratcliffe
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24
Class fails to detect if RSAN postgres user has been removed already, would like to do this for idempotency sake, however the procedure for removal will be to run puppet once with this class and uninstall the module