Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-2817) Consider the distributed architecture of PE_XL and make log scope configurable #81

Merged
merged 4 commits into from Dec 3, 2021

Conversation

MartyEwings
Copy link
Collaborator

@MartyEwings MartyEwings commented Nov 26, 2021

Prior to this commit:

  • it was not possible to include pe-psql only nodes in the exporter class
  • corrective changes for unused schemas appeared on primary servers and pe-postgres servers
  • log dir was locked at /var/log/ scope, this can now be optional set to /var/log/puppetlabs

@MartyEwings MartyEwings added the enhancement New feature or request label Nov 26, 2021
@puppet-community-rangefinder
Copy link

rsan::exporter is a class

that may have no external impact to Forge modules.

rsan::remove_exporter is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link

@Adam-Shambrook Adam-Shambrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as discussed with Marty

Copy link

@Adam-Shambrook Adam-Shambrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as discussed

@MartyEwings MartyEwings changed the title Consider the distributed architecture of PE_XL Consider the distributed architecture of PE_XL and make log scope configurable Nov 26, 2021
@MartyEwings MartyEwings linked an issue Nov 26, 2021 that may be closed by this pull request
@MartyEwings MartyEwings changed the title Consider the distributed architecture of PE_XL and make log scope configurable (SUP-2817) Consider the distributed architecture of PE_XL and make log scope configurable Nov 29, 2021
Copy link
Contributor

@BartoszBlizniak BartoszBlizniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes in my XL environment and everything worked.

  • pe-sql node successfully pulled logs
  • no corrective changes were seen on infra nodes
  • changed the log dir successfully
  • unmounted/mounted separate directories

@BartoszBlizniak BartoszBlizniak merged commit aec176f into puppetlabs:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants