New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(SUP-2817) Consider the distributed architecture of PE_XL and make log scope configurable #81
Conversation
rsan::exporter is a classthat may have no external impact to Forge modules. rsan::remove_exporter is a classthat may have no external impact to Forge modules. This module is declared in 0 of 578 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as discussed with Marty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as discussed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes in my XL environment and everything worked.
- pe-sql node successfully pulled logs
- no corrective changes were seen on infra nodes
- changed the log dir successfully
- unmounted/mounted separate directories
Prior to this commit: