Manage the maximum-pool-size configuration parameter in database.ini

puppetlabs · May 2, 2016 · 46f1b03 · 46f1b03
1 parent 98821c2
commit 46f1b03
Show file tree

Hide file tree

Showing 6 changed files with 72 additions and 39 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -69,6 +69,8 @@
   $temp_usage                        = $puppetdb::params::temp_usage,
   $certificate_whitelist_file        = $puppetdb::params::certificate_whitelist_file,
   $certificate_whitelist             = $puppetdb::params::certificate_whitelist,
+  $database_max_pool_size            = $puppetdb::params::database_max_pool_size,
+  $read_database_max_pool_size       = $puppetdb::params::read_database_max_pool_size,
 ) inherits puppetdb::params {
 
   class { '::puppetdb::server':
@@ -136,6 +138,8 @@
     temp_usage                        => $temp_usage,
     certificate_whitelist_file        => $certificate_whitelist_file,
     certificate_whitelist             => $certificate_whitelist,
+    database_max_pool_size            => $database_max_pool_size,
+    read_database_max_pool_size       => $read_database_max_pool_size,
   }
 
   if ($database == 'postgres') {

diff --git a/manifests/params.pp b/manifests/params.pp
@@ -20,14 +20,15 @@
   $postgres_version          = '9.4'
 
   # The remaining database settings are not used for an embedded database
-  $database_host       = 'localhost'
-  $database_port       = '5432'
-  $database_name       = 'puppetdb'
-  $database_username   = 'puppetdb'
-  $database_password   = 'puppetdb'
-  $database_ssl        = undef
-  $jdbc_ssl_properties = ''
-  $database_validate   = true
+  $database_host          = 'localhost'
+  $database_port          = '5432'
+  $database_name          = 'puppetdb'
+  $database_username      = 'puppetdb'
+  $database_password      = 'puppetdb'
+  $database_ssl           = undef
+  $jdbc_ssl_properties    = ''
+  $database_validate      = true
+  $database_max_pool_size = '25'
 
   # These settings manage the various auto-deactivation and auto-purge settings
   $node_ttl               = '0s'
@@ -57,6 +58,7 @@
   $read_conn_max_age                 = '60'
   $read_conn_keep_alive              = '45'
   $read_conn_lifetime                = '0'
+  $read_database_max_pool_size       = '25'
 
   $manage_firewall         = true
   $java_args               = {}

diff --git a/manifests/server.pp b/manifests/server.pp
@@ -64,6 +64,8 @@
   $temp_usage                        = $puppetdb::params::temp_usage,
   $certificate_whitelist_file        = $puppetdb::params::certificate_whitelist_file,
   $certificate_whitelist             = $puppetdb::params::certificate_whitelist,
+  $database_max_pool_size            = $puppetdb::params::database_max_pool_size,
+  $read_database_max_pool_size       = $puppetdb::params::read_database_max_pool_size,
 ) inherits puppetdb::params {
   # deprecation warnings
   if $database_ssl != undef {
@@ -151,6 +153,7 @@
     database_password      => $database_password,
     database_name          => $database_name,
     database_ssl           => $database_ssl,
+    database_max_pool_size => $database_max_pool_size,
     jdbc_ssl_properties    => $jdbc_ssl_properties,
     database_validate      => $database_validate,
     database_embedded_path => $database_embedded_path,
@@ -167,21 +170,22 @@
   }
 
   class { 'puppetdb::server::read_database':
-    database            => $read_database,
-    database_host       => $read_database_host,
-    database_port       => $read_database_port,
-    database_username   => $read_database_username,
-    database_password   => $read_database_password,
-    database_name       => $read_database_name,
-    database_ssl        => $read_database_ssl,
-    jdbc_ssl_properties => $read_database_jdbc_ssl_properties,
-    database_validate   => $read_database_validate,
-    log_slow_statements => $read_log_slow_statements,
-    conn_max_age        => $read_conn_max_age,
-    conn_keep_alive     => $read_conn_keep_alive,
-    conn_lifetime       => $read_conn_lifetime,
-    confdir             => $confdir,
-    notify              => Service[$puppetdb_service],
+    database               => $read_database,
+    database_host          => $read_database_host,
+    database_port          => $read_database_port,
+    database_username      => $read_database_username,
+    database_password      => $read_database_password,
+    database_name          => $read_database_name,
+    database_ssl           => $read_database_ssl,
+    database_max_pool_size => $read_database_max_pool_size,
+    jdbc_ssl_properties    => $read_database_jdbc_ssl_properties,
+    database_validate      => $read_database_validate,
+    log_slow_statements    => $read_log_slow_statements,
+    conn_max_age           => $read_conn_max_age,
+    conn_keep_alive        => $read_conn_keep_alive,
+    conn_lifetime          => $read_conn_lifetime,
+    confdir                => $confdir,
+    notify                 => Service[$puppetdb_service],
   }
 
   if str2bool($ssl_set_cert_paths) == true

diff --git a/manifests/server/database.pp b/manifests/server/database.pp
@@ -19,6 +19,7 @@
   $conn_keep_alive        = $puppetdb::params::conn_keep_alive,
   $conn_lifetime          = $puppetdb::params::conn_lifetime,
   $confdir                = $puppetdb::params::confdir,
+  $database_max_pool_size = $puppetdb::params::database_max_pool_size,
 ) inherits puppetdb::params {
 
   if str2bool($database_validate) {
@@ -147,4 +148,9 @@
     setting => 'conn-lifetime',
     value   => $conn_lifetime,
   }
+
+  ini_setting { 'puppetdb_database_max_pool_size':
+    setting => 'maximum-pool-size',
+    value   => $database_max_pool_size,
+  }
 }
diff --git a/manifests/server/read_database.pp b/manifests/server/read_database.pp
@@ -1,21 +1,22 @@
 # PRIVATE CLASS - do not use directly
 class puppetdb::server::read_database (
-  $database            = $puppetdb::params::read_database,
-  $database_host       = $puppetdb::params::read_database_host,
-  $database_port       = $puppetdb::params::read_database_port,
-  $database_username   = $puppetdb::params::read_database_username,
-  $database_password   = $puppetdb::params::read_database_password,
-  $database_name       = $puppetdb::params::read_database_name,
-  $database_ssl        = $puppetdb::params::read_database_ssl,
-  $jdbc_ssl_properties = $puppetdb::params::read_database_jdbc_ssl_properties,
-  $database_validate   = $puppetdb::params::read_database_validate,
-  $log_slow_statements = $puppetdb::params::read_log_slow_statements,
-  $conn_max_age        = $puppetdb::params::read_conn_max_age,
-  $conn_keep_alive     = $puppetdb::params::read_conn_keep_alive,
-  $conn_lifetime       = $puppetdb::params::read_conn_lifetime,
-  $confdir             = $puppetdb::params::confdir,
-  $puppetdb_user       = $puppetdb::params::puppetdb_user,
-  $puppetdb_group      = $puppetdb::params::puppetdb_group,
+  $database               = $puppetdb::params::read_database,
+  $database_host          = $puppetdb::params::read_database_host,
+  $database_port          = $puppetdb::params::read_database_port,
+  $database_username      = $puppetdb::params::read_database_username,
+  $database_password      = $puppetdb::params::read_database_password,
+  $database_name          = $puppetdb::params::read_database_name,
+  $database_ssl           = $puppetdb::params::read_database_ssl,
+  $jdbc_ssl_properties    = $puppetdb::params::read_database_jdbc_ssl_properties,
+  $database_validate      = $puppetdb::params::read_database_validate,
+  $log_slow_statements    = $puppetdb::params::read_log_slow_statements,
+  $conn_max_age           = $puppetdb::params::read_conn_max_age,
+  $conn_keep_alive        = $puppetdb::params::read_conn_keep_alive,
+  $conn_lifetime          = $puppetdb::params::read_conn_lifetime,
+  $confdir                = $puppetdb::params::confdir,
+  $puppetdb_user          = $puppetdb::params::puppetdb_user,
+  $puppetdb_group         = $puppetdb::params::puppetdb_group,
+  $database_max_pool_size = $puppetdb::params::read_database_max_pool_size,
 ) inherits puppetdb::params {
 
   # Only add the read database configuration if database host is defined.

diff --git a/spec/unit/classes/server/database_ini_spec.rb b/spec/unit/classes/server/database_ini_spec.rb
@@ -118,6 +118,14 @@
              'setting' => 'conn-lifetime',
              'value'   => '0'
              )}
+      it { should contain_ini_setting('puppetdb_database_max_pool_size').
+        with(
+             'ensure'  => 'present',
+             'path'    => '/etc/puppetlabs/puppetdb/conf.d/database.ini',
+             'section' => 'database',
+             'setting' => 'maximum-pool-size',
+             'value'   => '25'
+             )}
     end
 
     describe 'when using a legacy PuppetDB version' do
@@ -226,6 +234,14 @@
              'setting' => 'conn-lifetime',
              'value'   => '0'
              )}
+      it { should contain_ini_setting('puppetdb_database_max_pool_size').
+        with(
+             'ensure'  => 'present',
+             'path'    => '/etc/puppetdb/conf.d/database.ini',
+             'section' => 'database',
+             'setting' => 'maximum-pool-size',
+             'value'   => '25'
+             )}
     end
 
     describe 'when overriding database_path for embedded' do