Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ntp dependency to spec_helper_acceptance #263

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Move ntp dependency to spec_helper_acceptance #263

merged 2 commits into from
Jun 30, 2017

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Jun 30, 2017

aac7181 added this dependency but it's only needed in the acceptance tests.

@ekohl
Move ntp dependency to spec_helper_acceptance
60f225a 
aac7181 added this dependency but it's
only needed in the acceptance tests.
@ekohl ekohl mentioned this pull request Jun 30, 2017
Merged
dhollinger
dhollinger approved these changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though is there a possibility that we may not need to set anything NTP related to get the acceptance tests to work?

@ekohl
Copy link
Contributor Author

ekohl commented Jun 30, 2017

I'll try that.

@ekohl
Copy link
Contributor Author

ekohl commented Jun 30, 2017

Looks like the acceptance tests passed without the NTP module.

@mullr mullr merged commit 389fcaf into puppetlabs:master Jun 30, 2017
@ekohl ekohl deleted the move-ntp-dependency branch June 30, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhollinger dhollinger dhollinger approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ekohl @dhollinger @mullr @smortex