Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cater for multiple server_urls #351

Closed
wants to merge 3 commits into from

Conversation

bassonj
Copy link

@bassonj bassonj commented Mar 16, 2022

Documentation at puppet.com states that multiple server_urls can be specified

You can use a comma-separated list of URLs if there are multiple PuppetDB instances available. A server_urls config that supports two PuppetDBs would look like:

server_urls = https://puppetdb1.example.com:8081,https://puppetdb2.example.com:8081

This MR changes the puppet_server String into an Array and runs .map on it to allow for multiple puppetdb servers to be specified

@bassonj bassonj requested a review from a team as a code owner March 16, 2022 15:31
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

puppetdb::master::config is a class

Breaking changes to this file WILL impact these 8 modules (exact match):
Breaking changes to this file MAY impact these 3 modules (near match):

puppetdb::master::puppetdb_conf is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@binford2k
Copy link
Member

Also, we probably want a couple spec updates in https://github.com/puppetlabs/puppetlabs-puppetdb/tree/main/spec/unit/classes/master to validate behaviors

bassonj and others added 2 commits March 30, 2022 12:44
Updated approach and spec test to allow for either String or Array and not introduce any regression
@bassonj
Copy link
Author

bassonj commented Mar 30, 2022

I've updated the approach to deal with either a String or an Array of strings so no regression is introduced.
I've also updated the specs to the best of my abilities.

Please let me know if there's anything else that needs to happen to expedite the acceptance of this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants