Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix dynamic-scope resource defaults #356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

op-ct
Copy link

@op-ct op-ct commented Aug 8, 2022

Prior to this patch, many classes in the puppetdb module overrode
the Ini_setting type with their own (different) parameters & values,
resulting in a Russian roulette of dynamically-scoped default parameters
wherever ini_setting is used.

This patch converts all dynamically-scoped parameter "defaults" for the
Ini_settings type to use Hash-bashed attributes and local resource
defaults instead.

@op-ct op-ct requested a review from a team as a code owner August 8, 2022 23:19
@puppet-community-rangefinder
Copy link

puppetdb::master::puppetdb_conf is a class

that may have no external impact to Forge modules.

puppetdb::master::storeconfigs is a class

that may have no external impact to Forge modules.

puppetdb::server::command_processing is a class

that may have no external impact to Forge modules.

puppetdb::server::database is a class

that may have no external impact to Forge modules.

puppetdb::server::global is a class

that may have no external impact to Forge modules.

puppetdb::server::jetty is a class

that may have no external impact to Forge modules.

puppetdb::server::puppetdb is a class

that may have no external impact to Forge modules.

puppetdb::server::read_database is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@op-ct op-ct changed the title (maint) Remove dynamic-scoped resource defaults (maint) Fix dynamic-scoped resource defaults Aug 18, 2022
@op-ct op-ct changed the title (maint) Fix dynamic-scoped resource defaults (maint) Fix dynamic-scope resource defaults Aug 18, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants