Update firewall manifests to use jump instead of action

[david22swan]

As part of the Firewall module rewrite the functionality of the action attribute has been rolled into the jump attribute, the two of them both managing the Firewall jump value.

[joshcooper]

Is the jump parameter supported by all versions of the firewall module listed in metadata.json?

[david22swan]

jump was always present, action was created to represent 3 different possible values that can be passed to the iptables jump value but with the release of v7.0.0 action has been removed and jump is now one value.

It was an odd piece of code added to enforce the use of those 3 values above any of the others. There would likely be errors from this if used alongside versions of firewall less than 7, but is needed for versions greater than 7. You may need to label this backwards incompatible and do an x release

[joshcooper]

There would likely be errors from this if used alongside versions of firewall less than 7, but is needed for versions greater than 7.

Should this be bumped to >= 7 and < 8?

puppetlabs-puppetdb/metadata.json

Line 21 in 4a02618

"version_requirement": ">= 1.1.3 < 7.0.0"

[david22swan]

There would likely be errors from this if used alongside versions of firewall less than 7, but is needed for versions greater than 7.

Should this be bumped to >= 7 and < 8?

puppetlabs-puppetdb/metadata.json

Line 21 in 4a02618

"version_requirement": ">= 1.1.3 < 7.0.0"

Updated.
Sorry on the wait, was on PTO friday

[corporate-gadfly]

Any thoughts on a release?

[david22swan]

@joshcooper Could you take a look

[joshcooper]

Seems ok to me, but honestly I have no idea.

[austb]

Since this will require an X release, I am planning to do a release of the changes that have landed on main before we merge this.

[smortex]

Looks good to go when we are ready for a major version bump

[corporate-gadfly]

Looks good to go when we are ready for a major version bump

Any estimates on when approximately that might be?

[corporate-gadfly]

Looks good to go when we are ready for a major version bump

Any updates? TY.

[rafiqueh]

Looks good to go when we are ready for a major version bump

Happy New Year. Any updates?

[david22swan]

@austb Thoughts on when this could go in?

[bastelfreak]

@david22swan looks good to me. maybe correct BUDFIX? :D and I think we should keep this as breaking change because it bumps a dependency by a view versions.

[david22swan]

Had BUGFIX just because I didn't have a ticket for it.
Does this look better?
Or at least more accurate

[bastelfreak]

Can you unpin the module in https://github.com/puppetlabs/puppetlabs-puppetdb/blob/main/.fixtures.yml#L22 ? Then tests should/could pass.