Correct clientcert value in pg_hba.conf for Postgresql >= 12 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhunt-steds
requested review from
bastelfreak,
smortex and
a team
as code owners
|
|
|
@jhunt-steds thanks for the PR, can you please rebase? |
jhunt-steds
force-pushed
the
postgres-ssl-clientcert-fix
branch
from
d3f3435
to
66737ab
Compare
|
Sorry, I apparently did the rebase in some wrong way that closed the PR for some reason; I'm not really a developer and don't understand git well, but it at least does apply cleanly now I think. |
|
Apologies again, it appears I forgot to run the linter/tests after my rebase yesterday. Everything should be correct now. |
h0tw1r3
approved these changes
Feb 9, 2024
bastelfreak
reviewed
Feb 9, 2024
bastelfreak
approved these changes
Feb 9, 2024
|
Looks like the failing checks were the result of some network error rather than the changes themselves. Both contain a Ruby stack trace from the first test that has this line: |
h0tw1r3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12 and up, that is.
PuppetDB 8.0.0 requires Postgresql 14 or later, but starting in 12 the syntax for the clientcert option in pg_hba.conf changed. This PR implements the new syntax when a newer version of Postgresql is requested by the user.