Fix custom database port support #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tw1r3
requested review from
bastelfreak,
smortex and
a team
as code owners
bastelfreak
reviewed
Feb 16, 2024
bastelfreak
approved these changes
Feb 16, 2024
smortex
added a commit
that referenced
this pull request
May 2, 2024
The changes introduced in #392 require changes that where introduced in version 10.0.0 of the puppetlabs-postgresql module, but the lower version of the module was not properly updated in this PR. Fix the lower bound of the dependency to indicate that version 10 of the puppetlabs-postgresql module is required for proper operation. Fixes #401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very helpful to be able to switch ports on a major version change.
Found while testing upgrading from 7.14.0 to 8.0.0 (to be released) of this module
Testing also revealed, deploying to an existing setup (eg. puppetdb + postgresql 11), postgresql 14 server will be deployed but unable to start (port in use by postgresql 11).