Recursively manage permission. #76

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@nanliu
Contributor
nanliu commented Oct 25, 2012

No description provided.

@nanliu
Contributor
nanliu commented Oct 25, 2012

This is related to: puppetlabs/Razor#227

There's probably other rough edges since this is not very well tested:

  • new files in the /opt/razor directory when importing images.
  • default owner/permission for new files?
  • non-root user mounting images.

I would like to get some feedback before we pull this change into the module.

@slippycheeze
Contributor

@nanliu, what further questions do we have about this?

@slippycheeze
Contributor

@nanliu, what further questions did you have about this change before it was merged?

@slippycheeze slippycheeze commented on an outdated diff Dec 11, 2012
manifests/init.pp
@@ -89,11 +89,14 @@
}
file { $directory:
- ensure => directory,
- mode => '0755',
- owner => $username,
- group => $username,
- require => Vcsrepo[$directory],
+ ensure => directory,
+ mode => '0755',
@slippycheeze
slippycheeze Dec 11, 2012 Contributor

Shouldn't his be 0644, rather than 0755, since we don't want to set permissions on all files to "executable"?

@slippycheeze
Contributor

We should revisit this once we figure out the migration to Rack in Razor, and how that changes the security model. I think it is still totally sane as-is, but until the end of that change we should probably delay putting this in.

@puppetcla

CLA Signed by nanliu on 2011-10-05 21:00:00 -0700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment