Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Recursively manage permission. #76

Closed
wants to merge 1 commit into from

Conversation

nanliu
Copy link
Contributor

@nanliu nanliu commented Oct 25, 2012

No description provided.

@nanliu
Copy link
Contributor Author

nanliu commented Oct 25, 2012

This is related to: https://github.com/puppetlabs/Razor/issues/227

There's probably other rough edges since this is not very well tested:

  • new files in the /opt/razor directory when importing images.
  • default owner/permission for new files?
  • non-root user mounting images.

I would like to get some feedback before we pull this change into the module.

@slippycheeze
Copy link
Contributor

@nanliu, what further questions do we have about this?

@slippycheeze
Copy link
Contributor

@nanliu, what further questions did you have about this change before it was merged?

group => $username,
require => Vcsrepo[$directory],
ensure => directory,
mode => '0755',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't his be 0644, rather than 0755, since we don't want to set permissions on all files to "executable"?

@slippycheeze
Copy link
Contributor

We should revisit this once we figure out the migration to Rack in Razor, and how that changes the security model. I think it is still totally sane as-is, but until the end of that change we should probably delay putting this in.

@puppetcla
Copy link

CLA Signed by nanliu on 2011-10-05 21:00:00 -0700

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants