(MODULES-2658) Detect DSC pending reboot state #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
force-pushed
the
ticket/master/MODULES-2658-dsc-lcmstate-pending
branch
from
2f61aaa
to
6443086
Compare
- Use WMI to query the MSFT_DSCLocalConfigurationManager class of the DSC namespace to retrieve the LCMState property. When the LCMState is set to 'PendingReboot', then the machine is pending a reboot. Note that we can only mock out the WMI interactions, and that writing a valid acceptance test is not easy at this time given this functionality depends on WMF5. CI pipelines are not yet configured with WMF5, so these changes will require some manual validation.
Iristyle
force-pushed
the
ticket/master/MODULES-2658-dsc-lcmstate-pending
branch
from
6443086
to
63145f0
Compare
Iristyle
changed the title
|
LGTM |
| WIN32OLE.expects(:connect).with(root).returns(dsc) | ||
| dsc.expects(:Get).with('MSFT_DSCLocalConfigurationManager').returns(lcm) | ||
| lcm.expects(:ExecMethod_).with('GetMetaConfiguration').returns(ole_config) | ||
| ole_config.expects(:MetaConfiguration).returns(dsc_meta_config) |
There was a problem hiding this comment.
Stub stub stub it out. Haha
There was a problem hiding this comment.
Sadly, not much choice here.
ferventcoder
added a commit
that referenced
this pull request
Oct 7, 2015
…cmstate-pending (MODULES-2658) Detect DSC pending reboot state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.