(MODULES-6528) Fix registry::value defined type #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
force-pushed
the
MODULES-6528-fix-registry-value-defined-type
branch
from
94122fc
to
4f5a86e
Compare
- Demonstrate the bug introduced in the 2.0.0 release as part of 48a0b07 - Tests for dword, qword and array type values currently fail given the defined type doesn't properly type the $data value to allow numeric values or arrays.
- Fix the bug introduced in 48a0b07 that did not have lenient enough typing for the $data parameter to the registry::value defined type. - This commit adds support for numerics, which are necessary for dword and qword. It also adds support for arrays, which are always an array of strings (corresponding to REG_MULTI_SZ).
Iristyle
force-pushed
the
MODULES-6528-fix-registry-value-defined-type
branch
from
4f5a86e
to
e36dc74
Compare
Iristyle
commented
Jan 26, 2018
| end | ||
|
|
||
| ['dword', 'qword'].each do |type| |
There was a problem hiding this comment.
The tests here cover all the valid types per https://github.com/puppetlabs/puppetlabs-registry#type - string, array, dword, qword, binary and expand
| @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| #### Fixed | |||
There was a problem hiding this comment.
Just noticed our use of header here is inconsistent... I copied the prior which was using ####, but now see most (but not all!) are using ###
michaeltlombardi
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate the bug introduced in the 2.0.0 release as part of
48a0b07
Tests for dword, qword and array type values currently fail in the first
commit given the defined type doesn't properly type the $data value to
allow numeric values or arrays.
Fix the bug introduced in 48a0b07
that did not have lenient enough typing for the $data parameter to
the registry::value defined type.
This commit adds support for numerics, which are necessary for
dword and qword. It also adds support for arrays, which are always
an array of strings (corresponding to REG_MULTI_SZ).