(#14529) Add registry::value defined type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshcooper 0533126 is ready for review. |
| registry_key { "${key}": } | ||
| } | ||
|
|
||
| registry_value { "${pre32}${key}\\${value_real}": |
There was a problem hiding this comment.
pre32 shouldn't be here.
|
Addressed my own comment. c506e14 should be good to go. |
Without this patch we don't have an easy to use way to abstract away the
management of a value and the key it's in.
This patch fixes the problem by creating a new defined resource type in
Puppet that builds on top of the native `registry_key` and
`registry_value` resource types.
This registry::value type allows the user to manage values without
worrying about also managing the key the value exists in. For example:
registry::value { 'MyAPP - Owner Email':
key => 'HKLM\Software\Puppet Labs',
value => 'Owner Email',
data => 'jeff@puppetlabs.com',
}
This resource will automatically manage the parent key if it does not
exist and manage the value. The key and value will be created in the
native architecture of the hive. That is to say, the 64 bit hive on a
64 bit system and the 32 bit hive on a 32 bit system.
joshcooper
added a commit
that referenced
this pull request
May 16, 2012
(#14529) Add registry::value defined type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
(#14529) Add registry::value defined type
Without this patch we don't have an easy to use way to abstract away the
management of a value and the key it's in.
This patch fixes the problem by creating a new defined resource type in
Puppet that builds on top of the native
registry_keyandregistry_valueresource types.This registry::value type allows the user to manage values without
worrying about also managing the key the value exists in. For example:
This resource will automatically manage the parent key if it does not
exist and manage the value. The key and value will be created in the
native architecture of the hive. That is to say, the 64 bit hive on a
64 bit system and the 32 bit hive on a 32 bit system.