Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #26 from hunner/add_travis" #28

Merged
merged 1 commit into from Aug 1, 2013

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Aug 1, 2013

The tests for this module are run internally. The current test systems are failing on loading puppetlabs_spec_helper and are not using bundler, so this change should be backed out.

This reverts commit 5b852fe, reversing changes made to b9c4f3a.

This reverts commit 5b852fe, reversing
changes made to b9c4f3a.
@hunner
Copy link
Contributor Author

hunner commented Aug 1, 2013

#24 should still be reviewed.

hunner added a commit that referenced this pull request Aug 1, 2013
Revert "Merge pull request #26 from hunner/add_travis"
@hunner hunner merged commit ed22d38 into puppetlabs:master Aug 1, 2013
@hunner hunner deleted the revert_travis branch August 1, 2013 23:21
@trlinkin
Copy link
Contributor

trlinkin commented Aug 2, 2013

@hunner Maybe just accept #24 for the time being, do a release, and then do a larger refactor of the spec code later?

@hunner
Copy link
Contributor Author

hunner commented Aug 2, 2013

Sorry, but this is @joshcooper or @jeffmccune's call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants