(maint) Fix major typo #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have to bump the package release? |
This fixes a major issue with our release packages. There's a dependency on redhat-release that's based on the platform version. However, when we changed the platform version to not be the package version, this broke that logic. This commit hopefully fixes it.
melissa
force-pushed
the
maint/master/fuck
branch
from
a479477
to
62d54d0
Compare
|
👍 |
1 similar comment
|
👍 |
|
FTR I reported the bug here: https://tickets.puppetlabs.com/browse/CPR-378 |
|
@melissa Thanks for your awesome responsiveness. |
|
@EmilienM it's the least I can do for breaking things |
|
@melissa we're all humans :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a major issue with our release packages. There's a dependency
on redhat-release that's based on the platform version. However, when we
changed the platform version to not be the package version, this broke
that logic. This commit hopefully fixes it.