Install rsync-daemon in CentOS >= 8 when not using xinetd

[amoralej]

Since CentOS 8, rsyncd systemd unit is shipped in a different package,
rsync-dameon. When setting use_xinetd to false in rsync::server, this
package should be installed for CentOS >= 8.

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

rsync::server is a class

Breaking changes to this file WILL impact these 2 modules (exact match):

• openstack-swift
• stackforge-swift

Breaking changes to this file MAY impact these 2 modules (near match):

• jtopjian-havana
• simp-simp

This module is declared in 33 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[amoralej]

Linter job is failing:

5 files inspected, 459 offenses detected

RuboCop failed!

(459!), i guess this is unrelated with this review and must be because of some change in CI, any help with how to proceed here?

[kajinamit]

@binford2k Could you please have a look ? I'm reaching out to you because I was you approved the last pull request but please let me know if you want me to reach out to the other person. I really appreciate your help here ?

Note that Robocop test keeps failing, maybe because of new rules enforced now.

[kajinamit]

Please find my feedback.
Also, we should update metadata.json. It doesn't include CentOS8 and the logic you added to the spec file is not triggered.

[kajinamit]

Thanks. LGTM.