Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't insert the address option if not specified. #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Nov 29, 2021

The previous default made rsyncd an IPv4 only service by default.
This change instead uses the rsyncd default when unset. This
easily allows dual stack services to provide rsyncd.

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

rsync::server is a class

that may have no external impact to Forge modules.

This module is declared in 30 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Collaborator

@kajinamit kajinamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the change. Please see my inline comments.

Also, it seems you have not yet signed CLA, which is required to approve this change later.

templates/header.erb Show resolved Hide resolved
manifests/server.pp Outdated Show resolved Hide resolved
@jcpunk jcpunk force-pushed the noaddress branch 2 times, most recently from 3b763a6 to d53eba8 Compare November 30, 2021 15:31
@jcpunk
Copy link
Contributor Author

jcpunk commented Nov 30, 2021

Should be fixed up now.

@kajinamit
Copy link
Collaborator

Sorry for the delay in merge. Had some trouble with my account permission.
Do you mind rebasing this on the current master to resolve conflict ?

Copy link
Collaborator

@kajinamit kajinamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing my vote because rebase is needed

@jcpunk
Copy link
Contributor Author

jcpunk commented Mar 30, 2023

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants