(MODULES-4758) Update satellite for Puppet 4 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbondpdx
suggested changes
Apr 21, 2017
There was a problem hiding this comment.
One other thing is that the paragraphs aren't lined up correctly after the numbered steps. Each paragraph following an ordered step should indented to wherever the text after the number or letter starts. So:
-
Order text like this.
You line it up this way, but you don't have to break and indent long lines.
Only if you have another paragraph after.
README.md
Outdated
|
|
||
| If you do not want the Satellite server to verify the Puppet master identity, then in the Satellite UI, go to *Administer -> Settings -> Auth* and set the `restrict_registered_puppetmasters` parameter to false. | ||
|
|
||
| Note that this setting presents a security risk, as false reports and facts can be sent to Satellite by a malicious system masquerading as a current Puppet master on your infrastructure that's been added to Satellite as a safe master. | ||
|
|
||
| 5. Enable pluginsync and reports in Puppet | ||
|
|
||
| On each Puppet agent, make sure the [`pluginsync`](https://docs.puppetlabs.com/references/latest/configuration.html#pluginsync) and [`report`](https://docs.puppetlabs.com/references/latest/configuration.html#report) settings are enabled. (Normally, these settings are enabled by default.) | ||
| On each Puppet agent, make sure the [`pluginsync`](https://docs.puppet.com/references/latest/configuration.html#pluginsync) and [`report`](https://docs.puppet.com/references/latest/configuration.html#report) settings are enabled. (Normally, these settings are enabled by default.) |
There was a problem hiding this comment.
would you be kind enough to take /references out of this URL? It does redirect, so it's no big deal if it stays,but we got rid of the references subfolder.
README.md
Outdated
| @@ -146,21 +146,45 @@ processor and facts indirector to communicate with Satellite. | |||
|
|
|||
| #### Parameters | |||
|
|
|||
| * `manage_default_ca_cert` - Applicable to Red Hat-based systems only. When set to true, the module transfers the Satellite server's default CA certificate from the Satellite server to the master. This uses an untrusted SSL connection. Defaults to true. | |||
| `manage_default_ca_cert` | |||
There was a problem hiding this comment.
These parameter names should be set as h5 headers.
README.md
Outdated
|
|
||
| * `ssl_ca` - The file path to the CA certificate used to verify the satellite server identitity. Not used if `verify_satellite_certificate` is set to false. Default: `/etc/puppetlabs/puppet/ssl/ca/katello-default-ca.crt`. | ||
| Applicable to Red Hat-based systems only. When set to true, the module transfers the Satellite server's default CA certificate from the Satellite server to the master. This uses an untrusted SSL connection. Defaults to true. |
README.md
Outdated
|
|
||
| Data type: String. | ||
|
|
||
| The file path to the CA certificate used to verify the satellite server identitity. Not used if `verify_satellite_certificate` is set to false. Default: `/etc/puppetlabs/puppet/ssl/ca/katello-default-ca.crt`. |
This adds Puppet 4 data types and puppet-strings docs to init.pp. This also includes updates to the README for PE version and Puppet 4 parameter documentation.
ccaum
approved these changes
Apr 24, 2017
eputnam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Puppet 4 data types and puppet-strings docs to init.pp. This also includes updates to the README for PE version and Puppet 4 parameter documentation.