New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test explicit json dep on 2.4 #23
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
force-pushed
the
json-dep-test-for-PDK
branch
8 times, most recently
from
March 23, 2018 15:31
bde9cc9
to
d8be95f
Compare
Iristyle
force-pushed
the
json-dep-test-for-PDK
branch
2 times, most recently
from
March 23, 2018 16:57
310f833
to
b213412
Compare
TODO: look for "native extension" in the output |
Iristyle
force-pushed
the
json-dep-test-for-PDK
branch
from
March 23, 2018 22:13
92e76b8
to
981f71e
Compare
Iristyle
force-pushed
the
json-dep-test-for-PDK
branch
from
March 23, 2018 22:17
981f71e
to
2c96ce1
Compare
Can this PR be closed? |
Hello @Iristyle, In order to merge this PR, please resolve the conflicts and rebase it with the latest code. Thanks! |
Closing as un-needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merely a test to evaluate what happens when json is required explicitly.
It should use the system gem, not install a new native
2.1.0
gem.