Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test explicit json dep on 2.4 #23

Closed
wants to merge 10 commits into from

Conversation

Iristyle
Copy link
Contributor

This is merely a test to evaluate what happens when json is required explicitly.

It should use the system gem, not install a new native 2.1.0 gem.

@Iristyle Iristyle force-pushed the json-dep-test-for-PDK branch 8 times, most recently from bde9cc9 to d8be95f Compare March 23, 2018 15:31
@Iristyle Iristyle force-pushed the json-dep-test-for-PDK branch 2 times, most recently from 310f833 to b213412 Compare March 23, 2018 16:57
@Iristyle
Copy link
Contributor Author

TODO: look for "native extension" in the output

@glennsarti
Copy link
Contributor

Can this PR be closed?

@lionce
Copy link
Contributor

lionce commented Apr 18, 2019

Hello @Iristyle,

In order to merge this PR, please resolve the conflicts and rebase it with the latest code.

Thanks!

@tphoney
Copy link
Contributor

tphoney commented Aug 29, 2019

Closing as un-needed

@tphoney tphoney closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants