(MODULES-7319) Call "semodule --list" only once. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montaguethomas
force-pushed
the
feature/selmodule-perf
branch
4 times, most recently
from
39b208f
to
99b598d
Compare
Add method to base class to statically load results of "semodule --list" command. Store output parsed into hash with keys being module name and value being module version. Add prefetch method to initially populate hash. This change results in a substantial performance increase when checking current resource state, on the order of 50% or more.
montaguethomas
force-pushed
the
feature/selmodule-perf
branch
from
99b598d
to
4602f9b
Compare
gimmyxd
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to base class to statically load results of
"semodule --list" command. Store output parsed into hash with keys
being module name and value being module version. Add prefetch method
to initially populate hash.
This change results in a substantial performance increase when checking
current resource state, on the order of 50% or more.