Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-1363) Parameter name changes and removals #212

Merged
merged 2 commits into from Mar 20, 2024

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Mar 15, 2024

Summary

In preparation for v2 of this module, this commit removes the deprecated reports parameter, renames the collect_facts parameter, and adds two new parameters for event forwarding credentials.

Detailed Description

  • manifests/init.pp
    • Added token_events and url_events parameters for event forwarding.
    • Removed deprecated reports parameter.
    • Renamed collect_facts -> facts_allowlist.
  • files/hec_secrets.yaml.epp
    • Added event token to template.
  • templates/settings.yaml.epp
    • Added event url to template.
  • templates/util_splunk_hec.erb
    • Renamed custom source_type for event forwarding.
  • lib/puppet/indirector/facts/splunk_hec.rb
    • Removed comment regarding collect_facts parameter name.
  • spec/classes/init_spec.rb
    • Removed unit test against deprecated reports parameter.
  • Updated README.md
  • Updated REFERENCE.md
  • Updated CHANGELOG.md
  • Maintenance:
    • manifests/init.pp - Ensure sensitivate data is redacted from logs.

Checklist

[X] Ensure README is updated
[X] Any changes to existing documentation
[X] Anything new added
[X] Unit Tests
[ ] Acceptance Tests
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@coreymbe coreymbe requested a review from a team as a code owner March 15, 2024 18:22
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@actowery actowery merged commit 7448325 into puppetlabs:main Mar 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants