Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) replaced debian6 by centos7 master in nodesets yml files #124

Conversation

phongdly
Copy link
Contributor

Debian is no longer supported for master from Shallow Gravy. This PR replaced debian6 by Centos7 for master node in Nodesets yml files.

@Iristyle
Copy link
Contributor

@phongdly could you can change subject to (maint) from (Maintenance)? You can also add [skip ci] to the commit message to prevent it from running through AppVeyor / TravisCI given there's no need here.

@Iristyle
Copy link
Contributor

Also @phongdly could you restore the original filenames of the node definitions? Those specific names are hardcoded into the Jenkins jobs - for example https://jenkins-modules.puppetlabs.com/view/3.%20windows%20only/view/sqlserver/view/master/job/modules_puppetlabs-sqlserver_intn-sys_core-master-foss-stable/

With the filenames changed, the jobs will break.

@phongdly phongdly changed the title (Maintenance) replaced debian6 by centos7 master in nodesets yml files (maint) replaced debian6 by centos7 master in nodesets yml files Jul 23, 2015
@phongdly phongdly force-pushed the maintenance/remove-debian6-master-in-nodesets branch from b83aea9 to 784c1b2 Compare July 23, 2015 18:39
(maint) revert file names back to original names

[skip ci]
@phongdly phongdly force-pushed the maintenance/remove-debian6-master-in-nodesets branch from 784c1b2 to 2238258 Compare July 23, 2015 18:40
Iristyle added a commit that referenced this pull request Jul 23, 2015
…er-in-nodesets

(maint) replaced debian6 by centos7 master in nodesets yml files
@Iristyle Iristyle merged commit cb53ed5 into puppetlabs:master Jul 23, 2015
@Iristyle Iristyle deleted the maintenance/remove-debian6-master-in-nodesets branch July 23, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants