(DO NOT MERGE)(MODULES-2312) Use sp_executesql to execute T-SQL #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SQL server module executed arbitrary TSQL by
injecting user supplied data into a template verbatim. Unfortunately
this mechanism does nothing to address syntax errors, which will
prevent the try / catch mechanism employed from working and
propagating errors.
The stored procedure sp_executesql can be used to execute arbitrary
SQL strings, and will properly propagate an exception that can be
caught, so use that method.
Of note, since the user query is being placed into a string, it must
have single quotes escaped properly. An additional test has been
added to verify that single quotes are escaped as expected.