(MODULES-2391) Create Automated Tests For sqlserver_instance 2015-08-26 #134
Conversation
| } | ||
| MANIFEST | ||
|
|
||
| inst_value = inst_name |
There was a problem hiding this comment.
Why not just use the same values, there isn't much reason to create additional resources for this.
There was a problem hiding this comment.
Good catch, I changed back and forth the way to get the instance name and forgot to clean it. Will change it to use the same value, run it again and update the PR
phongdly
force-pushed
the
MODULES-2391/SQLSERVER-Create_Automated_Tested_for_sqlserver-instance
branch
from
1314aca
to
ccd1f3b
Compare
| } | ||
| MANIFEST | ||
|
|
||
| ensure_value = ensure_val |
There was a problem hiding this comment.
We still have this value assigned for no reason, just use ensure_val instead of creating another variable.
|
@cyberious updated! |
|
|
||
| before(:all) do | ||
| ensure_sqlserver_instance(host, features, inst_name, 'absent') | ||
| remove_sql_features(host, {:features => features, :version => version}) |
There was a problem hiding this comment.
This method will always return true because :acceptable_exit_codes => [0, 1, 2]. That doesn't seem right, can you explain why this always returns true?
There was a problem hiding this comment.
Hmm... I reused the method without catching it accepts exit code 1. I'll talk to Travis on this one when he's back.
I'll update the code and remove the use of it in this PR which only need to create and delete instances
|
@phongdly I keep seeing the following errors during the test run, yet no test failures: |
|
@cowofevil The error occurred because it was trying to uninstall non-existing features in the effort of making the environment clean before install features |
|
@cowofevil updated! |
|
@phongdly There is no good way to tell which TestRail test cases are addressed by tests. I would suggest using the meta-tags styles from WSUS: https://github.com/puppetlabs/puppetlabs-wsus_client/blob/master/spec/acceptance/wsus_client_spec.rb#L92 |
|
Very nice suggestion, I was actually looking for something like that to connect the automated tests to TestRail test cases. Thanks |
…utomated_Tested_for_sqlserver-instance (MODULES-2391) Create Automated Tests For sqlserver_instance 2015-08-26
cowofevil
deleted the
MODULES-2391/SQLSERVER-Create_Automated_Tested_for_sqlserver-instance
branch
| end | ||
| end | ||
|
|
||
| context "server_url =>", {:testrail => ['88978', '89028', '89031', '89043', '89061']} do |
There was a problem hiding this comment.
server_url tells me nothing about what this should be doing, can we go back and specify the context in clear text I it will make debugging failures a lot more clear.
No description provided.