(MODULES-2392) Automated Tests for sqlserver::config #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phongdly I think these tests would be stronger if you validated that the resource that you are attempting to create (database , login) where actually created. This assumes that the credentials contained in sqlserver::config are required to create those resources. |
| @@ -75,6 +77,24 @@ def run_sql_query(host, opts = {}, &block) | |||
| end | |||
| end | |||
|
|
|||
| def run_simple_sql_query(host, opts = {}) | |||
There was a problem hiding this comment.
Should you remove the 'run_sql_query' method? Im not sure if that old method is ever used. It seems like this new method had the same purpose, the difference being that this method works. :)
There was a problem hiding this comment.
I personally like the way 'run_sql_query' was implemented, I think it's better to consolidate the two methods in the next sprint.
|
@zreichert : updated |
zreichert
added a commit
that referenced
this pull request
Aug 26, 2015
…est_sqlserver-config (MODULES-2392) Automated Tests for sqlserver::config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.