Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-2498) generate random instance name in each context #145

Conversation

phongdly
Copy link
Contributor

@phongdly phongdly commented Sep 1, 2015

delete an instance and then create another instance with the same name without rebooting cause CI failure.
This PR to create random instance name in each context to avoid the above issue.

@cyberious
Copy link
Contributor

While we are updating this file can we updated the contexts from 'server_url =>' to something meaningful as far as context?

@phongdly
Copy link
Contributor Author

phongdly commented Sep 1, 2015

@cyberious :updated

context "server_url =>", {:testrail => ['88978', '89028', '89031', '89043', '89061']} do

features = ['SQL', 'SQLEngine', 'Replication', 'FullText', 'DQ']
context "server_url => https://testrail.ops.puppetlabs.net/index.php?/cases/view/88978 : Create an instance", \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer no URL in this and what does context server_url mean... I would say just

context "Create an instance", {:testrail => [1,2,3]} do

(MODULES-2498) added url link and msg to context after server_url =>

(MODULES-2498) update context message
@phongdly phongdly force-pushed the MODULES-2498/modify-automated-tests-for-ci branch from 92fc608 to 043a212 Compare September 1, 2015 23:28
cyberious added a commit that referenced this pull request Sep 2, 2015
…ests-for-ci

(MODULES-2498) generate random instance name in each context
@cyberious cyberious merged commit 5bdcdad into puppetlabs:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants