(MODULES-3355) Fix Role Name Collisions #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
changed the title
If sqlserver::role is specified more than one for the same role
non-unique titles will be generated for the sqlserver_tsql that
will handle the operations. This is likely to happen if setting
up heira configs like this:
'sqlserver::role':
‘User_1’:
role: db_owner
database: FooBar
instance: MSSQLSERVER
members:
- ‘User_1’
type: 'DATABASE'
‘User_2’:
role: db_owner
database: Wakka
instance: MSSQLSERVER
members:
- ‘User_2’
type: 'DATABASE'
This fix introduces the database name into the title created for
the sqlserver_tsql statements so that it is unique.
jpogran
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sqlserver::role is specified more than one for the same role
non-unique titles will be generated for the sqlserver_tsql that
will handle the operations. This is likely to happen if setting
up heira configs like this:
'sqlserver::role':
‘User_1’:
role: db_owner
database: FooBar
instance: MSSQLSERVER
members:
- ‘User_1’
type: 'DATABASE'
‘User_2’:
role: db_owner
database: Wakka
instance: MSSQLSERVER
members:
- ‘User_2’
type: 'DATABASE'