(MODULES-3355) Fix acceptance tests for Sqlserver role #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 2f18a68 fixes sqlserver::role to allow multiple role declarations for the same role name. This introduced a bug by not changing the sqlserver_tsql title in the require paramter for sqlserver::role::permissions. This only occurs when permissions are specified. This fixes acceptance tests by ensuring the require statement for the role permissions is the same as the tile for the tsql statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2f18a68 fixes
sqlserver::role to allow multiple role declarations for
the same role name. This introduced a bug by not changing
the sqlserver_tsql title in the require paramter for
sqlserver::role::permissions. This only occurs when
permissions are specified.
This fixes acceptance tests by ensuring the require statement
for the role permissions is the same as the tile for
the tsql statement