(MODULES-4667) Update beaker tests for Jenkins CI #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the SQL Server Module used its own CA Certs function and assumed that all hosts marked with agent are Windows platforms. This commit removes the custom CA certificate installation and instead uses the installation from the puppet_install_helper gem. This commit also changes the provisioning process to use hosts marked with 'sql_host' instead of assuming all agents were Windows platforms: for example a Puppet Master is also an agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the SQL Server Module used its own CA Certs function and assumed that
all hosts marked with agent are Windows platforms. This commit removes the
custom CA certificate installation and instead uses the installation from the
puppet_install_helper gem. This commit also changes the provisioning process
to use hosts marked with 'sql_host' instead of assuming all agents were Windows
platforms: for example a Puppet Master is also an agent.