(MODULES-5030) Remove service_ensure parameter #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the service_ensure parameter was defined in the type however it was never implemented in the provider. As such this param had no effect. This commit removes the parameter because: - This parameter is confusing as it is only applicable at installation time, not constantly enforced - Each service can have a different startup type. This is already possible using the install_switches e.g. /BROWSERSVCSTARTUPTYPE=Disabled - Ongoing Windows service state should really be managed by a puppet manifest not by an installation switch
jpogran
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the service_ensure parameter was defined in the type however it was
never implemented in the provider. As such this param had no effect. This
commit removes the parameter because:
not constantly enforced
using the install_switches e.g. /BROWSERSVCSTARTUPTYPE=Disabled
not by an installation switch