(MODULES-2386) Using as_sysadmin_accounts without AS feature should error #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror Previously if the as_sysadmin_accounts parameter was set however the required AS feature was not in the feature list, then the SQL installation would proceed and not install AS. This commit changes the behaviour of the provider to fail the resource if the as_sysadmin_accounts is set in the sql_instance resource without the required AS feature in the feature list on creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the as_sysadmin_accounts parameter was set however the required
AS feature was not in the feature list, then the SQL installation would proceed
and not install AS. This commit changes the behaviour of the provider to fail
the resource if the as_sysadmin_accounts is set in the sql_instance resource
without the required AS feature in the feature list on creation.