(FM-6141) Add test-tiering, and README to spec directory #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Jul 17, 2017
|
|
||
| # Get database name | ||
| db_name = ("DB" + SecureRandom.hex(4)).upcase | ||
| db_name = ('DB' + SecureRandom.hex(4)).upcase |
There was a problem hiding this comment.
I assume all the double to single quote conversions are just cleanup?
There was a problem hiding this comment.
Yeah, just cleanup.
Rakefile
Outdated
| desc 'test tiering' | ||
| RSpec::Core::RakeTask.new(:test_tier) do |t| | ||
|
|
||
| sh 'beaker-hostgenerator windows2012r2-64sql_host%2Cdefault.a%7Bsql_version=2012%7D-redhat7-64mdca --hypervisor abs > spec/acceptance/nodesets/hosts.yml' |
There was a problem hiding this comment.
Is this supposed to be here?
There was a problem hiding this comment.
Nope, I'll get rid of it.
| @@ -0,0 +1,82 @@ | |||
| # sqlserver testing | |||
There was a problem hiding this comment.
A different question. This SQL Server Module is localized. Does this mean this file should be too?
There was a problem hiding this comment.
I don't know the scope of localization as it pertains to test execution. I'll ping Jean.
glennsarti
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All acceptance tests have been marked as low risk for the purposes of test tiering and acceptance efficiency.