(MODULES-6022) Make SQLServer Instance Idempotent Again #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, applying a manifest that ensures a SQL instance is installed with any features will always attempt to uninstall and reinstall those features on subsequent applies. This was due to a bug in the code returning discovered features nested inside of a needless array. This commit rewrites the logic for retrieving the instance features to concatenate them into an array instead of mapping them, preventing the array-of-arrays problem entirely.
Prior to this commit, the acceptance tests for sqlserver instances do not verify idempotencies for the applied manifests. This allowed us to ship revisions of the code which passed the acceptance suite but were not idempotent, including critical failures such as causing each run to attempt to uninstall and reinstall all instance features. This commit updates the logic of the ensure_sqlserver_instance helper function to execute the specified manifest twice; once to test for failures when applying and a second time to ensure no changes are attempted when the manifest is re-applied. It also raises the test tier for tests which rely on this function to the high tier until after the next release.
|
This should be in a reviewable state now, but I'm considering adding a MAINT commit to update the other acceptance tests to check for idempotency as well. Kicking off this version in adhoc though. |
michaeltlombardi
changed the title
|
Passed adhoc last week, forgot to update here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with idempotency as a result of the changes in 2.0.1 to retrieve facts information from registry instead of WMI. Also updates acceptance tests to validate idempotency. Increases the test tier for changed tests to
highper @ThoughtCrhyme's suggestion.Supersedes #249 which was accidentally based on a branch on upstream instead of my fork. 🤦♂️