(MODULES-8721) README edit #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
suggested changes
Mar 8, 2019
README.md
Outdated
| > This `sid` does not look like a normal `sid` you might see outside of SQLServer, but it is returned as part of the detailed information to make it easier to correlate the logins returned by this module and query results from SQLServer. | ||
| > The `ADSID` property is a more normal looking `sid` you might get from PowerShell Active Directory query tools. | ||
| > It is a direct translation of that `SQLSID` into the Microsoft string `sid` form and will look something like `S-1-5-80-1402415987-66678372-3059512406-1823130485-2345841878`. | ||
| > This `sid` does not look like a normal `sid` you might see outside of SQLServer, but instead it is returned as part of the detailed information to make it easier to correlate the logins returned by this module and query results from SQLServer. |
There was a problem hiding this comment.
I don't think the word instead is needed here. The fact that it's being returned in the detailed information is not an alternative. The but here is to explain why it is that I'm returning data that may not look familiar to the user and to explain why.
There was a problem hiding this comment.
@RandomNoun7 I updated this.
clairecadman
force-pushed
the
sqlserver_doc_edits
branch
from
8fa07a3
to
14ce415
Compare
clairecadman
force-pushed
the
sqlserver_doc_edits
branch
from
14ce415
to
e28a162
Compare
|
@RandomNoun7 I think the formatting is back to how it was now. Let me know if this looks okay. Thanks! |
RandomNoun7
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes minor edits to the README.