(MODULES-8439) Fix sqlserver_instances custom fact #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
previously approved these changes
May 30, 2019
Prior to this commit, when a registry key in HKEY_LOCAL_MACHINE\Software\Microsoft\Microsoft SQL Server\Instance Names was missing the key about the current version the custom fact sqlserver_instances would throw an error message similar to this: 2019-01-06 14:55:09 -0500 Facter (err): error while resolving custom fact "sqlserver_instances": Failed to open registry key 'HKEY_LOCAL_MACHINE\Software\Microsoft\Microsoft SQL Server\MSRS11.@SharePoint\MSSQLServer\CurrentVersion': The system cannot find the file specified. This commit adds a check before trying to open the version information registry key.
michaeltlombardi
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.