(MODULES-6904) Restart SQL Server Service with Dependent Services #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
commented
Jun 6, 2019
metadata.json
Outdated
| }, | ||
| { | ||
| "name": "puppetlabs/powershell", | ||
| "version_requirement": ">= 1.0.0" |
There was a problem hiding this comment.
Worth noting that I did in fact test this on many versions of the powershell module starting with 1.0.1 which is the earliest version available on the forge.
There was a problem hiding this comment.
Just changed the version to >= 1.0.1 since that's the earliest on the forge.
RandomNoun7
force-pushed
the
tickets/MODULES-6904-restart-service
branch
from
753fb0e
to
8a66b99
Compare
|
looks grand, bar the check failing and the changelog. |
RandomNoun7
force-pushed
the
tickets/MODULES-6904-restart-service
branch
4 times, most recently
from
a16e5f3
to
211ffdf
Compare
Prviously, the sp_configure.pp file would attempt to use the builtin service resource to restart the MSSQLServer service if a configuration change was made. This attempt would fail if there was a dependent service such as the SQL Agent service, which is extremely common. This change implements an extremely small PowerShell script instead to force restart the MSSQLSERVER service, even if there are dependent services. In testing this resulted in the Agent service going down and then coming back up as expected.
RandomNoun7
force-pushed
the
tickets/MODULES-6904-restart-service
branch
from
211ffdf
to
35bb1a7
Compare
|
@tphoney Both the failing tests and the changelog issues have been addressed. See the ticket comments also for the passing adhoc run. |
tphoney
approved these changes
Jun 17, 2019
jpogran
reviewed
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prviously, the sp_configure.pp file would attempt to use the builtin
service resource to restart the MSSQLServer service if a configuration
change was made. This attempt would fail if there was a dependent
service such as the SQL Agent service, which is extremely common.
This change implements an extremely small PowerShell script instead to
force restart the MSSQLSERVER service, even if there are dependent
services.
In testing this resulted in the Agent service going down and then
coming back up as expected.