(MODULES-9912) ERB Template Errors #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, some ERB templates would cause jruby errors on the master during catalog compilation. The templates contained code that would attempt to modify the value of a frozen string. This change modifies the template code to ensure that no frozen string values are attempted to be modified. It also makes slight fixes to the syntax in the templates to ensure that each instance of this pattern is written more consistantly.
|
Looks good but is missing a test for the behaviour? Although does https://github.com/puppetlabs/puppetlabs-sqlserver/blob/master/spec/defines/user/permissions_spec.rb#L97-L111 cover it? |
glennsarti
approved these changes
Sep 16, 2019
|
|
|
As per conversation with @RandomNoun7 , there is some unit testing for upcasing, however what is really needed is a full audit. This work is being tracked in https://tickets.puppetlabs.com/browse/MODULES-9917. Happy for merge now. |
RandomNoun7
deleted the
tickets/MODULES-9912-fix-template-frozen-string-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, some ERB templates would cause jruby errors
on the master during catalog compilation. The templates contained code
that would attempt to modify the value of a frozen string.
This change modifies the template code to ensure that no frozen string
values are attempted to be modified.
It also makes slight fixes to the syntax in the templates to ensure that
each instance of this pattern is written more consistantly.