FM-1900 Add User defined type #68
Conversation
| validate_re($password, '^.{8,128}$', 'Password must be bewteen 8 and 128 characters') | ||
| validate_re($password,'[A-Z]{1,}','Password must contain at least one uppercase letter') | ||
| validate_re($password,'[a-z]{1,}','Password must contain at least one lowercase letter') | ||
| validate_re($password,'\W+','Password must contain at least one special character') |
There was a problem hiding this comment.
I'm a little confused about why we're enforcing password requirements here. Any rules in place on the SQL Server side should bounce out an error message about unmet requirements.
Also, FYI - password length is a stronger indicator of security than inclusion of upper / lower / special characters.
There was a problem hiding this comment.
This is to ensure we fail fast and we know these requirements so if we can do thing ahead of spinning up powershell twice it would be preferential.
There was a problem hiding this comment.
I understand - but given the user can configure the password policy, I don't think this is appropriate here.
There was a problem hiding this comment.
I can understand the special character and maybe the one uppercase and lowercase but length I believe is a rule across the board, especially on max length.
There was a problem hiding this comment.
Those errors will bubble up to the user so I am fine, just let me know if you are vieamently apposed to the validation. I am sure most if not all DBA's would at least want the top three met. A number is another one we didn't check for. Most of the time however the password will not even be used as the authentication will be done at the login level not the user level. Only in a contained database will password even be available.
|
Pinned rspec-puppet to ~> 1.0 as it broke expectations with release of 2.0 |
| @@ -5,6 +5,7 @@ script: "bundle exec rake spec SPEC_OPTS='--format documentation'" | |||
| rvm: | |||
| - 1.9.3 | |||
| - 2.0.0 | |||
| - 2.1.5 | |||
|
The commit message could use a bit of love. |
|
👍 to more info in commit message (including ticket number in subject) |
|
Updated commit message to reference ticket. |
| # | ||
| # | ||
| # | ||
| ## |
There was a problem hiding this comment.
Is this reserved for comments?
There was a problem hiding this comment.
Yes, I have yet to do the comments on this defined type. Docs will be there, still not done with this defined type.
FM-1900 Add User defined type
No description provided.