New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadjson: do not send http_basic_authentication if not needed #1208
Conversation
loadjson is a functionBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 318 of 578 indexed public
|
Hi @chaen, this change looks good, however there are still a couple of minor syntax issues that need to be addressed. |
Hi @carabasdaniel sorry for the delay. |
@chaen Look's like we're getting a few failures in the spec tests i you could give them a closer look |
Hi @david22swan For the other error (puppet 6.0), I am happy to try and correct, but I have a very hard time reproducing (puppetlabs/iac#317 (comment)). Any help in that direction is more than welcome ! |
I've rebased PR on to main so we have got the latest changes. It will also let us see the logs of the failing task. @chaen is this still something that you would like to work on? |
Thanks @chelnak I am still interested in making it work, but I don't have much time to dedicate to it. So I can give it another go, hoping I don't bump into puppetlabs/iac#317 (comment) anymore |
Excellent! Thank you for your response. Let's see what happens & try to get this one resolved. |
This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days. |
loadjson is a functionBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 318 of 579 indexed public
|
loadjson is a functionBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 318 of 579 indexed public
|
Hello! 👋 This pull request has been open for a while and has had no recent activity. We've labelled it with If you are waiting on a response from us we will try and address your comments on a future Community Day. Alternatively, if it is no longer relevant to you please close the PR with a comment. Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error. |
Hi @chaen, We've rebased your PR onto main. The spec tests that are failing are not directly related to your changes. Your changes will now be merged. Thanks for contributing! 🙂 |
Hi @petergmurphy |
I came across storages that return HTTP 400 if sent basic auth (S3). This PR only sends the
username
/password
parameters if needed.