Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass calling scope to stdlib::ensure_packages from shim #1366

Merged
merged 1 commit into from Jun 15, 2023

Commits on Jun 15, 2023

  1. Pass calling scope to stdlib::ensure_packages from shim

    Make the `ensure_packages` shim an Internal function and pass scope to
    the namespaced version so as to not change the behaviour of where
    packages are contained.
    
    When the function was first ported to the new API, it was discussed that
    the existing behaviour might not be 'correct', but changing it would be
    a breaking change that might have consequences for many users.
    
    In namespacing the function in 9.0.0 we accidentally created a situation
    where the namespaced version worked as before, but the non-namespaced
    version, (the shim), now behaved differently.
    
    Fixes puppetlabs#1374
    alexjfisher committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a68c958 View commit details
    Browse the repository at this point in the history