Add use_strict_setting parameter to deprecation function
#1378
Conversation
In this change, an optional third parameter is added to the `deprecation` function. The default behaviour remains the same, but when the third parameter is set to `false`, Puppet's `strict` setting is ignored. This means that even if `strict` is set to `error`, no exception will be raised when this function is called, and a warning will be logged instead. This is a prerequisite for puppetlabs#1373
alexjfisher
requested review from
a team,
b4ldr,
bastelfreak,
ekohl,
smortex and
seanmil
as code owners
|
Are the acceptance tests expected? |
@chelnak Sorry, not following. How do you mean? Are you referring to the failing tests that github is highlighting? (If so, I think those are all the tests marked as |
|
Ha! I was trying to multitask and failed. Yes I was referring to the failed test. It's unusual for a pending test to make the run red. Can you just double check it? |
Which failed test? I can't see any that are red. |
|
I think it was transient! I re-kicked the failed one and it's green now. |
ah, thanks. That makes more sense now. Thought one of us was seeing things! :) |
In this change, an optional third parameter is added to the
deprecationfunction. The default behaviour remains the same, but when the third parameter is set tofalse, Puppet'sstrictsetting is ignored. This means that even ifstrictis set toerror, no exception will be raised when this function is called, and a warning will be logged instead.This is a prerequisite for #1373