Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#9080) Add facts from /etc/puppetlabs/facts.d #14

Merged

Conversation

jeffmccune
Copy link
Contributor

This fact is a direct copy of R.I.'s work at
https://github.com/ripienaar/facter-facts

This is necessary plumbing to allow the installer to write a simple text
file based on the role the node is receiving. For example:

$ cat /etc/puppetlabs/facts.d/puppet_enterprise_mcollective.txt
fact_stomp_port=61613
fact_stomp_server=puppetmaster
fact_is_puppetagent=true
fact_is_puppetmaster=true

The mcollectivepe module relies on these facts being set and we need a
persistent place to write them during the interview process and later
read them when puppet agent runs to configure MCollective on the agent
systems.

Since stdlib is a public module, both /etc/facts.d and
/etc/puppetlabs/facts.d are scanned for static facts.

This fact is a direct copy of R.I.'s work at
https://github.com/ripienaar/facter-facts

This is necessary plumbing to allow the installer to write a simple text
file based on the role the node is receiving.  For example:

    $ cat /etc/puppetlabs/facts.d/puppet_enterprise_mcollective.txt
    fact_stomp_port=61613
    fact_stomp_server=puppetmaster
    fact_is_puppetagent=true
    fact_is_puppetmaster=true

The mcollectivepe module relies on these facts being set and we need a
persistent place to write them during the interview process and later
read them when puppet agent runs to configure MCollective on the agent
systems.

Since stdlib is a public module, both /etc/facts.d and
/etc/puppetlabs/facts.d are scanned for static facts.
@jeffmccune jeffmccune merged commit 95c88a1 into puppetlabs:v2.x Aug 17, 2011
@lak
Copy link

lak commented Aug 18, 2011

You should at least be consistent with what's happening in Facter here - it looks like we're using /etc/facter/facts.d, which is what Mike decided on.

@jeffmccune
Copy link
Contributor Author

On Wed, Aug 17, 2011 at 8:29 PM, lak <
reply@reply.github.com>wrote:

You should at least be consistent with what's happening in Facter here - it
looks like we're using /etc/facter/facts.d, which is what Mike decided on.

Do you know if Facter's facts.d feature is API compatible with RIP's
facts.d?

If they are, I'm happy to make it use the same path, but if they're
incompatible I think there's good reason to keep them separate otherwise
we'll have issues with stdlib once Facter 2.0 is released.

-Jeff

@lak
Copy link

lak commented Aug 18, 2011

On Thu, Aug 18, 2011 at 9:26 AM, jeffmccune <
reply@reply.github.com>wrote:

On Wed, Aug 17, 2011 at 8:29 PM, lak <
reply@reply.github.com>wrote:

You should at least be consistent with what's happening in Facter here -
it
looks like we're using /etc/facter/facts.d, which is what Mike decided
on.

Do you know if Facter's facts.d feature is API compatible with RIP's
facts.d?

If they are, I'm happy to make it use the same path, but if they're
incompatible I think there's good reason to keep them separate otherwise
we'll have issues with stdlib once Facter 2.0 is released.

You're right - I don't think they're compatible, and it makes sense to keep
them separate in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants